Updating crossgen to pass -nologo by default #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI. @dotnet/cli-contrib |
livarcocc
approved these changes
May 2, 2018
|
Do you want this is 2.2.100 (master) or 2.1.400 (release/2.1.4xx)? |
eerhardt
reviewed
May 2, 2018
| @@ -166,7 +166,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <!-- Create profiling symbols if requested --> | |||
| <MakeDir Directories="$(CrossgenProfilingSymbolsOutputDirectory)" | |||
| Condition="'$(CreateProfilingSymbols)' == 'true' and Exists($(CrossgenOutputAssembly))" /> | |||
| <Exec Command="$(CrossgenExe) -readytorun -platform_assemblies_paths $(CrossgenPlatformAssembliesPath) -$(CreateProfilingSymbolsOptionName) $(CrossgenProfilingSymbolsOutputDirectory) $(CrossgenOutputAssembly)" | |||
| <Exec Command="$(CrossgenExe) -nologo -readytorun -platform_assemblies_paths $(CrossgenPlatformAssembliesPath) -$(CreateProfilingSymbolsOptionName) $(CrossgenProfilingSymbolsOutputDirectory) $(CrossgenOutputAssembly)" | |||
There was a problem hiding this comment.
Do you also want to pass -nologo in on line 144?
eerhardt
approved these changes
May 2, 2018
|
Retargeted to release/2.1.4xx |
|
Does anyone know if there is already coreclr (right repo?) bug tracking making crossgen spew less noise (besides the logo)? If not I will file one. T Things like 'tail calls are not supported' and 'cannot resolve [hex]' over and over with zero information as to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1404